This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Return AFHTTPRequestOperation in failure blocks. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is actually a patch for issue #84, after reading into it further. |
nickhrsn
force-pushed
the
authentication-error
branch
from
df3ab14 to
54f07d4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit allows authentication failures to be processed in the same way as a standard AFNetworking request.
Processing HTTP response codes on an authentication request is messy when the only parameter being returned is an
NSError. Instead of translating NSError codes, I opted for returning theoperationas well; just like regular AFNetworking requests.This problem was identified while shifting the OzGuild platform to OAuth 2.0, and I thought it would be useful to others in a similar position.