Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asssistant video download instruction banner text #90

Merged

Conversation

twinkarma
Copy link
Contributor

@twinkarma twinkarma commented Jul 11, 2024

@twinkarma
Copy link
Contributor Author

@Sallaa @ttramb here's some text for the upcoming video services fix. Struggling with combining html tags and Arabic. Do you have any advice?

@Sallaa
Copy link
Contributor

Sallaa commented Jul 11, 2024

@twinkarma What is your workflow to get the Arabic translations? I have found that LLMs get the best results for generating these TSV lines.

I know that @dteyssou is also using Google Translate but I think it breaks the html tags

@twinkarma
Copy link
Contributor Author

I've also been using google translate. Will be using LLM to do the initial translation from now on, thanks! I've also fixed the illegal quoting issue and the table should render correctly on github now.

@Sallaa
Copy link
Contributor

Sallaa commented Jul 11, 2024

Great! Do you need to do any more change or is it ready to be merged?

@twinkarma
Copy link
Contributor Author

I've not had the translations checked yet, let me put it to the GATE team first

@twinkarma
Copy link
Contributor Author

@Sallaa do you have anyone who can verify Greek, Italian and German translations on your side? If you it'd be great if we can get the last four rows checked:

https://github.com/twinkarma/InVID-Translations/blob/assistant/video-download-instructions/components/NavItems/tools/Assistant.tsv

Also does the French translation look ok to you?

@Sallaa
Copy link
Contributor

Sallaa commented Jul 30, 2024

I will ask @dteyssou to have a look this week. He could help with Italian and we may have someone at AFP for checking the German language. I also approved #92 so you may need to merge v0.82 into your branch

@Sallaa
Copy link
Contributor

Sallaa commented Aug 1, 2024

@twinkarma translations look good to me. Could you resolve the final conflicts? I will merge it after

@twinkarma twinkarma force-pushed the assistant/video-download-instructions branch from b046f71 to 078af60 Compare August 6, 2024 10:31
@twinkarma
Copy link
Contributor Author

Thanks @Sallaa , I've fixed the conflict

@Sallaa Sallaa merged commit 5068d29 into AFP-Medialab:v0.82 Aug 6, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants