Add comprehensive debugging messages. #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lumosis
force-pushed
the
lihao/dev
branch
2 times, most recently
from
f0432bb to
1032442
Compare
wyzhang
reviewed
Feb 10, 2025
| @@ -246,19 +251,26 @@ def __init__( | |||
| is_ray_backend: bool = False, | |||
| ): | |||
| if prefill_engines is None: | |||
| logger.warning("No prefill engines provided.") | |||
There was a problem hiding this comment.
Should we throw exception?
| # If we were blocking and hit the timeout, then retry the loop. | ||
| # Otherwise, we can exit and proceed to generation. | ||
| if block: | ||
| continue | ||
| else: | ||
| break | ||
|
|
||
| # Signal to kill the thread. |
There was a problem hiding this comment.
Intended to delete if new_request is None return?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable the comprehensive debug logging, set the logging level to
logging.DEBUGat line 103 and line 105.