removing tensorflow_text for aarch64 compatiblity #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdyro
force-pushed
the
rdyro-remove-tftxt
branch
3 times, most recently
from
646f83b
to
08378df
Compare
|
I'm not sure why Unit Test / Common test (v4-8) (pull_request) is failing |
rdyro
force-pushed
the
rdyro-remove-tftxt
branch
3 times, most recently
from
1f7ce19
to
bb1666a
Compare
gobbleturk
approved these changes
Sep 13, 2024
MaxText/tokenizer.py
Outdated
| for k in data_keys: | ||
| if isinstance(tokenizer, TikTokenTokenizer): | ||
| features[k] = tf.py_function(_process_string, [features[k]], Tout=[tf.int32])[0] | ||
| elif isinstance(tokenizer, SentencePieceTokenizer): | ||
| features[k] = tokenizer.encode(features[k]) | ||
| features[k] = tf.py_function(_process_string, [features[k]], Tout=[tf.int32])[0] |
There was a problem hiding this comment.
Did you check the performance here? Using a py_function for TikToken affected the performance and that's why the recommendation is to use pygrain/hf with tiktoken
There was a problem hiding this comment.
Ok, the performance consideration is something I completely missed. From some of my tests it's either tf.py_function or SentencePiece from sentencepiece that acquires the GIL and significantly impacts performance.
I looked into a bit, but for me even calling an empty tf.py_function throttles the loader down a lot (4x-6x).
Do you have any ideas? @khatwanimohit
rdyro
force-pushed
the
rdyro-remove-tftxt
branch
from
bb1666a
to
b750691
Compare
rdyro
force-pushed
the
rdyro-remove-tftxt
branch
from
b750691
to
d3ec05f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.