-
Notifications
You must be signed in to change notification settings - Fork 5
Compatibility for 2.7 release #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the old import works fine. Does it stop working in 2.8.0 for some reason? The versioning check is extra complexity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, never mind. The current code doesn't work on 2.7.
In order to make it work on both 2.7 and 2.8, I think simply
from torch_xla.experimental.custom_kernel import jax_env_context
Should work. LMK if not the case.
Unfortunately, |
ugh. you're right |
Later on, it would be good to add an E2E test verifying certain recipes with the 2.7 docker. Otherwise, we'd easily regress and random things may start breaking as changes get landed. |
This is not enough, there is a API compatibility issue which you fixed before:
I guess we can drop this PR and focusing on syncing docker image periodically. |
Maybe we could add an install sh script that downloads the right nightly version wheel corresponding to the pinned docker and installs them. To make the local installation process easier. |
jax_env_context
moved its location. Make the update to make sure 2.7 release is runnable.