-
Notifications
You must be signed in to change notification settings - Fork 5
Add SFT trainer and sft task #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hmm, very strange. Latest SFT run (https://github.com/AI-Hypercomputer/torchprime/actions/runs/15501248395/job/43649488239?pr=284) is taking forever to finish. Looks like it is compiling many graphs. In the past I've seen this happening when there are unexpected transfers from the TPU to the CPU (e.g. printing or calling |
@tengyifei Error is due to the export model in the end (so align with transfers from the TPU to the CPU as you mentioned). I don't know why, seems it worked with tpu vm. Any idea on how to debug this? |
I get a lot of notifications for this PR and it's also getting large. Can you work on smaller PRs that chain towards a bigger change, and, ask for more intermediate reviews? with unit tests, it's pretty easy to introduce small PRs that are 100 lines of code. https://google.github.io/eng-practices/review/developer/small-cls.html |
Please create a PR when ready for review, and make the PRs small - 100 lines of code is a good target. A PR that lives for days with 18 commits (not addressing comments) is getting too large. |
Enable SFT, specifically:
GSM8k training: