Skip to content

Fix autoprovisioning with spot nodes #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix autoprovisioning with spot nodes #186

wants to merge 1 commit into from

Conversation

avrittrohwer
Copy link
Collaborator

@avrittrohwer avrittrohwer commented Sep 18, 2024 •
edited
Loading

Fixes / Features

  • Fixes workload rendering when using spot, without this change xpk workload create errors like:

    [XPK] Waiting for `Creating Workload`, for 0 seconds
error: error parsing /tmp/tmp242uhnfs: error converting YAML to JSON: yaml: line 33: could not find expected ':'
[XPK] Task: `Creating Workload` terminated with code `1`

  • Adds required pod tolerations when using node auto-provisioning with spot nodes. Without the tolerations cluster autoscaler will not create new spot node pools.

Testing / Documentation

Node auto-provisioning with spot

  1. Created a xpk cluster with --spot flag.
  2. Created a workload with a different topology than the cluster default.
  3. Observed a nodepool being created with the new workload topology using spot TPU nodes.

Node auto-provisioning without spot

TODO

Not auto-provisioning

TODO

  • [ y/n ] Tests pass
  • [ y, not needed ] Appropriate changes to documentation are included in the PR

@avrittrohwer avrittrohwer force-pushed the avritt/spot branch 3 times, most recently from 19938b0 to 5ca8df3 Compare September 18, 2024 05:48
@avrittrohwer
Copy link
Collaborator Author

#187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Obliviour Obliviour Obliviour approved these changes

@44past4 44past4 Awaiting requested review from 44past4 44past4 will be requested when the pull request is marked ready for review 44past4 is a code owner

@sharabiani sharabiani Awaiting requested review from sharabiani sharabiani will be requested when the pull request is marked ready for review sharabiani is a code owner

@pawloch00 pawloch00 Awaiting requested review from pawloch00 pawloch00 will be requested when the pull request is marked ready for review pawloch00 is a code owner

@BluValor BluValor Awaiting requested review from BluValor BluValor will be requested when the pull request is marked ready for review BluValor is a code owner

@gcie gcie Awaiting requested review from gcie gcie will be requested when the pull request is marked ready for review gcie is a code owner

@RoshaniN RoshaniN Awaiting requested review from RoshaniN RoshaniN will be requested when the pull request is marked ready for review RoshaniN is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avrittrohwer @Obliviour