-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add smtplan+ #41
add smtplan+ #41
Conversation
Awesome! Thoughts...
|
We are down to 148 MB after a multi-stage build 😄. The solver binary is quite large and I don't plan on putting a lot of energy in to fixing that. KCL site says "SMTPlan+" I'll take this to mean we can use the name less the '+' for functional things, but keep it for documentation. I'm open to do whatever, and we can ping the KCL folks. I PR'd to the original repo using the FD model. |
Awesome stuff! There's been some discussion on maybe just pulling images from dockerhub (there's a way to do it via singularity, and it rebuilds the docker container as a singularity one). For now, though, I see no reason we can't pull from your shub lib. Only recommendation is to change the directory name -- from |
Done!
That is actually what my singularity definition does (from my image on dockerhub). |
Sorry, one last thing! Can you put in the size for the manifest? You can see how lama is install...
...and its the |
All set, thanks!! |
You should be able to pull the latest now, with smtplan intact. Thanks again! |
Inspired from some discussion here.
The image is nearly 1GB for now. A multi stage build is likely a next step.
Would it be good practice to add the singularity definition file into the packages directory since this doesn't exist in the smtplan repo?