Don't submit failed transactions to the mempool #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this prevents a SendNextPayment request from being made if make_payment() fails, thereby avoiding a panic in send_next_payment_to_destinations().
BHouwens
reviewed
May 13, 2024
| @@ -852,6 +852,8 @@ impl UserNode { | |||
| &mut self, | |||
| mempool_peer: SocketAddr, | |||
| ) -> Result<()> { | |||
| // TODO: having next_payment as part of the node is error-prone, it would be better to | |||
There was a problem hiding this comment.
Yeah, this was a last minute change made to accommodate an exchange, and still uses this weird async construction and sending structure. Would you like to make this change as part of this MR @DaMatrix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this prevents a SendNextPayment request from being made if make_payment() fails, thereby avoiding a panic in send_next_payment_to_destinations().
Changelog
Type of Change
Please mark the appropriate option by putting an "x" inside the brackets:
Checklist
Put an "x" in the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!
Screenshots (if applicable)
If the changes affect the UI or have visual effects, please provide screenshots or GIFs showcasing the changes.
Additional Context (if applicable)
Add any additional context or information about the changes that may be helpful in understanding the pull request.
Related Issues (if applicable)
If this pull request is related to any existing issues, please list them here.
Requested Reviewers
Mention any specific individuals or teams you would like to request a review from.