Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDSim: prevent use of unknown properties #1145

Merged
merged 5 commits into from
Jul 18, 2023
Merged

DDSim: prevent use of unknown properties #1145

merged 5 commits into from
Jul 18, 2023

Conversation

andresailer
Copy link
Member

BEGINRELEASENOTES

ENDRELEASENOTES

@andresailer
DDSim: ConfigHelper: prevent using unknown properties
01aa3c9 
Everywhere but in Meta, where we want to allow adding arbitrary information
@andresailer
CI: use newer stack for flake8 check
33014ff
@andresailer
DDCore.python.dd4hepFactories: fix string replacement issue (not enou…
0326fc9 
…gh %s)

we can just concatenate the strings like this. or better use textwrap.dedent and multiline strings.
@andresailer
Python: remove unnecessary parentheses from if statements
3d02771
@github-actions
Copy link

github-actions bot commented Jul 17, 2023 •
edited
Loading

Test Results

       6 files         6 suites   5h 52m 27s ⏱️
   358 tests    358 ✔️ 0 💤 0 ❌
1 058 runs  1 058 ✔️ 0 💤 0 ❌

Results for commit 1b2c070.

♻️ This comment has been updated with latest results.

@andresailer
Copy link
Member Author

well, it works

RuntimeError: OutputConfig error: Trying to add unknown propert(y/ies): {'myExtension'}!

Need to also not check OutputConfig, if using custom properties there is considered useful?

@andresailer andresailer merged commit 45310d1 into AIDASoft:master Jul 18, 2023
14 checks passed
@andresailer andresailer deleted the unknownProps branch July 18, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow etaMin, etaMax bounds in Geant4IsotropeGenerator and DDSim/Helper/Gun.py
1 participant
@andresailer