Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved _getEnviron to deal with multiple variables in the evaluated string #1159

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

bcouturi
Copy link
Contributor

Improved _getEnviron to deal with the case when multiple variables are to be evaluated in the string.
Previously it was only looking for the first ${ and the last }. I did a qucik fix that looks for all ${ } in the string. Using a parser or a library to do this would be better, but it seems that DDCore can be built without boost ?

BEGINRELEASENOTES

  • Improved _getEnviron to deal with the case when multiple variables are to be evaluated in the string
    ENDRELEASENOTES

DDCore/src/Handle.cpp Outdated Show resolved Hide resolved
DDCore/src/Handle.cpp Outdated Show resolved Hide resolved
Copy link
Contributor Author

@bcouturi bcouturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Included suggestions from A.Sailer

@github-actions
Copy link

Test Results

       6 files         6 suites   8h 0m 21s ⏱️
   358 tests    357 ✔️ 0 💤 1
1 058 runs  1 056 ✔️ 0 💤 2

For more details on these failures, see this check.

Results for commit f82a9b4.

@andresailer
Copy link
Member

Expected failures, and the "rich" again:
TEST: failed with average number of hits = 248.72 (expected 230+/-15)

@andresailer andresailer merged commit 87e34e9 into AIDASoft:master Aug 23, 2023
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants