Add warning if TGeo materialScan hits TGeoTessellated volumes. See gi… #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andresailer Hi Andre, is there some issue with /dev3 ? |
Yes @MarkusFrankATcernch this looks like an issue with dev3 |
Test Results 11 files 11 suites 4h 55m 16s ⏱️ For more details on these failures, see this check. Results for commit a331842. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
Add warning if TGeo materialScan hits TGeoTessellated volumes.
The DDRec MaterialManager and hence the corresponding MaterialScan use TGeo tracking through volumes.
Tracking in TGeo is not implemented for tessellated shapes as they result from CAD shapes. Though TGeo tracking is used
in the material scanner.... In TGeo tessellated surfaces behave like their bounding box. Hence they have no real shape
and for this reason you only see a "box".
TGeo tracking for tessellated shapes will only be implemented once TGeo moves to VecGeom. This will still take some time.
See github issue #1322 for details about the discussion.
ENDRELEASENOTES