Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for signal handling. Use in DDG4 #1336

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

MarkusFrankATcernch
Copy link
Contributor

@MarkusFrankATcernch MarkusFrankATcernch commented Oct 17, 2024

BEGINRELEASENOTES
Add implementation for signal handling.

  • The generic signal handler in DDCore may be used and specialized by applications as shon in the DDG4 package (see for details src/Geant4Kernel.h)
  • Use generic signal handler in DDG4 for controlled shutdown on CTRL-C.
  • Add test DDG4_SIGINT_handler in examples/DDG4
    to enable the signal handling use from python:
    geant4 = DDG4.Geant4(kernel, tracker='Geant4TrackerCombineAction')
    geant4.registerInterruptHandler() 
    
    Please note: The signal handler must be explicitly installed. DDG4 is a library framework and does not intervene in actions which users possibly want to handle themselves! This mechanism looks simple enough that it should not be annoying.
  • This MR should implement issue#1330 and supposedly supersedes PR#1300

ENDRELEASENOTES

… DDG4 for controlled shutdown on CTRL-C. Add test DDG4_SIGINT_handler in examples/DDG4
… DDG4 for controlled shutdown on CTRL-C. Add test DDG4_SIGINT_handler in examples/DDG4
@MarkusFrankATcernch MarkusFrankATcernch enabled auto-merge (rebase) October 17, 2024 16:31
Copy link

Test Results

   14 files     14 suites   5h 38m 43s ⏱️
  367 tests   366 ✅ 0 💤 1 ❌
2 524 runs  2 523 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 9f258ce.

DDG4/python/DDG4.py Outdated Show resolved Hide resolved
@andresailer andresailer merged commit 4364e5f into AIDASoft:master Oct 18, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants