Refactor schema evolution detection #844
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goal: Make it easier to use for comparing multiple versions of old schemas by avoiding to read information that remains the same multiple times
This was referenced Sep 12, 2025
Make everything to one thing and nothing more to disentangle concerns
tmadlener
force-pushed
the
refactor-schema-evol
branch
from
ce27a42 to
5e15702
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Partial lift of the changes from #828. The changes here do not yet include the change of grammar / format for the evolution files.
The main changes here are the splitting of the
DatamodelComparatorinto two bits, theDatamodelComparatorthat detects differences between two datamodels and theSchemaEvolutionJudgethat then determines whether these changes need manual intervention or not. It's a better split of responsibilities and should make it easier to adapt this whole functionality in the future. Additionally, it removes enough internal state from the whole machinery to make it possible, to re-use it for multiple schema versions.