Skip to content

Add ugly code to trigger an error when reading garbage #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ugly code to trigger an error when reading garbage #846

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f67bc07
Add code to trigger an error when reading garbage data
jmcarcell Sep 18, 2025
363ea4b
Add a [[maybe_unused]] to silence warnings
jmcarcell Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions python/templates/CollectionData.cc.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,21 @@
if (!isSubsetColl) {
m_data.reset(buffers.dataAsVector<{{ class.full_type }}Data>());

// The following is ugly code for the case when reading garbage data from ROOT
// after calling dataAsVector, which can trigger infinite loops that consume
// all the available memory and this works at least for GCC 15 and Clang 20 in
// {Debug,RelWithDebInfo,Release} modes.
// https://github.com/AIDASoft/podio/pull/817#issuecomment-3266748609 and
// https://github.com/AIDASoft/podio/pull/842
volatile std::uint64_t s = m_data->size();
if (s > 1e15) throw std::runtime_error("Bad data after reading: a collection is too big");
else
if (s == 0)
for ([[maybe_unused]] const auto& _ : *m_data.get())
throw std::runtime_error("Bad data after reading: zero-sized collection with data");
// end of ugly


{% for member in VectorMembers %}
m_vec_{{ member.name }}.reset(podio::CollectionReadBuffers::asVector<{{ member.full_type }}>(m_vecmem_info[{{ loop.index0 }}].second));
{% endfor %}
Expand Down