Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent failed applications from being saved in success.json #884

Merged
merged 4 commits into from
Dec 2, 2024
Merged

fix: prevent failed applications from being saved in success.json #884

merged 4 commits into from
Dec 2, 2024

Conversation

49Simon
Copy link
Collaborator

@49Simon 49Simon commented Nov 19, 2024 •
edited
Loading

fixes: #896

  • Removed unused import
  • Changed job_apply to raise an exception clearly indicating low suitability score.
  • If job fails due to low suitability score, it will be saved to skipped.json file now.

@49Simon 49Simon linked an issue Nov 19, 2024 that may be closed by this pull request
[BUG]: Adding jobs to success.json but not actually applying #852
Closed
@49Simon 49Simon self-assigned this Nov 19, 2024
@49Simon 49Simon mentioned this pull request Nov 19, 2024
Closed
@feder-cr feder-cr requested a review from sarob November 19, 2024 23:12
surapuramakhil
surapuramakhil previously requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@surapuramakhil surapuramakhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MR changes doesn't' make sense - looks like a hack.

@surapuramakhil surapuramakhil changed the base branch from hotfix/v2024.11.18 to release/v4.1.0 November 20, 2024 23:32
@surapuramakhil surapuramakhil removed the request for review from sarob November 21, 2024 00:15
@surapuramakhil surapuramakhil dismissed their stale review November 21, 2024 00:15

alternate reviewer

@49Simon 49Simon requested a review from sarob November 21, 2024 00:25
@surapuramakhil surapuramakhil mentioned this pull request Nov 25, 2024
Open
@49Simon 49Simon changed the title fix: prevent failed applications from saved in success.json fix: prevent failed applications from being saved in success.json Nov 25, 2024
@49Simon
Copy link
Collaborator Author

49Simon commented Nov 25, 2024

@surapuramakhil As requested, I've changed the flow and used custom exception.

@49Simon 49Simon removed a link to an issue Nov 25, 2024
[BUG]: Adding jobs to success.json but not actually applying #852
Closed
@49Simon 49Simon linked an issue Nov 25, 2024 that may be closed by this pull request
[BUG]: Jobs are not being applied to, despite log record's statements #928
Open
surapuramakhil
surapuramakhil requested changes Nov 25, 2024
View reviewed changes
src/custom_exception.py Show resolved Hide resolved
src/ai_hawk/linkedIn_easy_applier.py Show resolved Hide resolved
@surapuramakhil surapuramakhil removed the request for review from sarob November 26, 2024 12:50
@feder-cr
Copy link
Collaborator

feder-cr commented Dec 2, 2024

@surapuramakhil do you want merge or close this one?

1 similar comment
@feder-cr
Copy link
Collaborator

feder-cr commented Dec 2, 2024

@surapuramakhil do you want merge or close this one?

@surapuramakhil surapuramakhil merged commit cc0b814 into AIHawk-FOSS:release/v4.1.0 Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surapuramakhil surapuramakhil surapuramakhil approved these changes

Assignees

@49Simon 49Simon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Jobs are not being applied to, despite log record's statements
3 participants
@49Simon @feder-cr @surapuramakhil