Dev 539 #2536
Draft
Dev 539 #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunstefix
requested review from
josenriagu,
didd,
quininez and
SeverS
as code owners
Deploying akasha-core-framework with
|
| Latest commit: |
696c964
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://69162984.akasha-world-framework.pages.dev |
| Branch Preview URL: | https://dev-539.akasha-world-framework.pages.dev |
didd
requested changes
Feb 3, 2025
There was a problem hiding this comment.
@kunstefix the discussion we had was to place the error loader inisde the ui package. Otherwise we are introducing unnecessary confusion. None of the components in the ds core will be used going forward everything that will be used is in the ui package. And when you want to use this package in a specific extension you add it to the corresponding project.json file like we discussed before.
|
@kunstefix I have more review items on this PR ... to unblock Vali I created another PR for the error loader component #2538 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated ErrorLoader component to use shadcn-based components internally.
Issues that will be closed
Testing
Checklist