Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: adjust to changes of PushProtocolApi #2542

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Fix: adjust to changes of PushProtocolApi #2542

wants to merge 4 commits into from

Conversation

AndiAkasha
Copy link
Contributor

The PushProtocol API does not automatically subscribe the user to all channel notifications.
When fetching the user's notification settings via getSettingsOfUser(), an empty array may be returned
if the user has not explicitly opted in to any notifications. In this case, we:

  1. Fetch the default channel settings using getSettingsOfChannel().
  2. Mark these channel notifications as not selected (disabled) so that the user must perform an additional action to enable them.

Issues that will be closed

Testing

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • My commit message follows Conventional Commit Guideline

Copy link

cloudflare-workers-and-pages bot commented Feb 7, 2025

Deploying akasha-core-framework with  Cloudflare Pages  Cloudflare Pages

Latest commit: b313d8f
Status: ✅  Deploy successful!
Preview URL: https://f3a8b5b0.akasha-world-framework.pages.dev
Branch Preview URL: https://dev-637.akasha-world-framework.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants