Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper snackbars (from notisnack package) and major improvements #2

Merged
merged 5 commits into from
Aug 17, 2024
Merged

Add proper snackbars (from notisnack package) and major improvements #2

merged 5 commits into from
Aug 17, 2024

Conversation

wotoafagh
Copy link
Contributor

This pull request:

  • Adds proper snackbars (from notisnack package).
  • Adds proper loading page at App.tsx.
  • Fixes other major issues in the project.

@wotoafagh
Add proper snackbars (from notisnack package).
8e4aef9 
Add proper loading page at App.tsx.
Fix major issues.

Signed-off-by: wotoafagh <[email protected]>
@wotoafagh
Fix CI build errors.
8b8cc5f 
Signed-off-by: wotoafagh <[email protected]>
@wotoafagh
Add support for page query parameter in SearchUserPage.
afe675d 
Add extractErrorDetails function for extracting errors better.

Signed-off-by: wotoafagh <[email protected]>
@wotoafagh
Don't forget to set isEditing to false after user clicks on
447d6ce 
  save button.

Signed-off-by: wotoafagh <[email protected]>
@ALiwoto ALiwoto self-requested a review August 17, 2024 11:40
@ALiwoto ALiwoto added the enhancement New feature or request label Aug 17, 2024
@wotoafagh wotoafagh force-pushed the master branch 2 times, most recently from c18636a to 6d8da43 Compare August 17, 2024 12:21
ALiwoto
ALiwoto approved these changes Aug 17, 2024
View reviewed changes
Copy link
Owner

@ALiwoto ALiwoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ALiwoto ALiwoto merged commit aaabf88 into ALiwoto:master Aug 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ALiwoto ALiwoto ALiwoto approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wotoafagh @ALiwoto