Skip to content

Commit

Permalink
Allow subsetting simulation conditions in simulate_petab (#2199)
Browse files Browse the repository at this point in the history
simulate_petab was mainly intended to simulate all conditions at once,
but the `simulation_conditions` argument provides also an easy way to
simulate only a subset of conditions. However, this currently fails,
because the full parameter mapping is used an then wrong conditions
are assigned.

This is fixed here. Also it saved a minuscule amount of time.
  • Loading branch information
dweindl authored Nov 15, 2023
1 parent 1726f43 commit 48b8629
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions python/sdist/amici/petab_objective.py
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,7 @@ def create_parameter_mapping(
observable_df=petab_problem.observable_df,
mapping_df=petab_problem.mapping_df,
model=petab_problem.model,
simulation_conditions=simulation_conditions,
**dict(
default_parameter_mapping_kwargs, **parameter_mapping_kwargs
),
Expand Down

0 comments on commit 48b8629

Please sign in to comment.