Skip to content

Commit

Permalink
remove PK
Browse files Browse the repository at this point in the history
  • Loading branch information
FFroehlich committed Dec 2, 2024
1 parent c8667b5 commit 6718a1e
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions python/sdist/amici/jax/ode_export.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
from typing import (
TYPE_CHECKING,
)
from itertools import chain

import sympy as sp

Expand Down Expand Up @@ -202,7 +201,7 @@ def _generate_jax_code(self) -> None:
"x_rdata",
"total_cl",
)
sym_names = ("x", "tcl", "w", "my", "y", "sigmay", "x_rdata")
sym_names = ("p", "x", "tcl", "w", "my", "y", "sigmay", "x_rdata")

Check warning on line 204 in python/sdist/amici/jax/ode_export.py

View check run for this annotation

Codecov / codecov/patch

python/sdist/amici/jax/ode_export.py#L204

Added line #L204 was not covered by tests

indent = 8

Check warning on line 206 in python/sdist/amici/jax/ode_export.py

View check run for this annotation

Codecov / codecov/patch

python/sdist/amici/jax/ode_export.py#L206

Added line #L206 was not covered by tests

Expand Down Expand Up @@ -236,16 +235,6 @@ def _generate_jax_code(self) -> None:
# tuple of variable names (ids as they are unique)
**_jax_variable_ids(self.model, ("p", "k", "y", "x")),
**{
# in jax model we do not need to distinguish between p (parameters) and
# k (fixed parameters) so we use a single variable combining both
"PK_SYMS": "".join(
str(strip_pysb(s)) + ", "
for s in chain(self.model.sym("p"), self.model.sym("k"))
),
"PK_IDS": "".join(
f'"{strip_pysb(s)}", '
for s in chain(self.model.sym("p"), self.model.sym("k"))
),
"MODEL_NAME": self.model_name,
# keep track of the API version that the model was generated with so we
# can flag conflicts in the future
Expand Down

0 comments on commit 6718a1e

Please sign in to comment.