Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irreproducible segfault in python/examples/example_splines_swameye/ExampleSplinesSwameye2003.ipynb #2607

Closed
dweindl opened this issue Nov 28, 2024 · 1 comment · Fixed by #2612
Closed

irreproducible segfault in python/examples/example_splines_swameye/ExampleSplinesSwameye2003.ipynb #2607

dweindl opened this issue Nov 28, 2024 · 1 comment · Fixed by #2612
Labels
bug

Comments

@dweindl
Copy link
Member

dweindl commented Nov 28, 2024 •
edited
Loading

E.g. https://github.com/dweindl/AMICI/actions/runs/12068230279/job/33652887257 (EDIT: also: https://github.com/dweindl/AMICI/actions/runs/12117268489/job/33779361146)

The issue is probably in Model::clone:

Current thread 0x00007fbb17021b80 (most recent call first):
  File "/home/runner/work/AMICI/AMICI/python/sdist/amici/amici.py", line 5222 in clone
  File "/home/runner/work/AMICI/AMICI/venv/lib/python3.11/site-packages/pypesto/objective/amici/amici.py", line 298 in __deepcopy__

https://github.com/ICB-DCM/pyPESTO/blob/3b97e345b63b33297a0dbf7844f68328cc9a378b/pypesto/objective/amici/amici.py#L298
@dweindl dweindl added the bug label Nov 28, 2024
@dweindl
Copy link
Member Author

dweindl commented Nov 28, 2024

See also #2579. Apparently this wasn't fully fixed by #2583.

dweindl added a commit to dweindl/AMICI that referenced this issue Dec 2, 2024
@dweindl
Fix ModelStateDerived copy ctor
bb830ef 
SUNContext for `x_pos_tmp_` wasn't updated after copying.

Hopefully fixes AMICI-dev#2607.
@dweindl dweindl mentioned this issue Dec 2, 2024
Merged
@dweindl dweindl linked a pull request Dec 2, 2024 that will close this issue
Fix ModelStateDerived copy ctor #2612
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ModelStateDerived copy ctor dweindl/AMICI
1 participant
@dweindl