Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModelStateDerived copy ctor #2612

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 2, 2024

SUNContext for x_pos_tmp_ wasn't updated after copying.

Hopefully fixes #2607.

SUNContext for `x_pos_tmp_` wasn't updated after copying.

Hopefully fixes AMICI-dev#2607.
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.60%. Comparing base (2366c2e) to head (bb830ef).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2612      +/-   ##
===========================================
- Coverage    77.69%   77.60%   -0.10%     
===========================================
  Files          329      329              
  Lines        21708    21709       +1     
  Branches      1477     1477              
===========================================
- Hits         16866    16847      -19     
- Misses        4831     4851      +20     
  Partials        11       11              
Flag Coverage Δ
cpp 73.48% <100.00%> (-0.10%) ⬇️
cpp_python 34.14% <0.00%> (-0.01%) ⬇️
petab 36.96% <100.00%> (+0.01%) ⬆️
python 72.20% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/model_state.h 97.02% <100.00%> (+0.02%) ⬆️

... and 3 files with indirect coverage changes

@dweindl dweindl self-assigned this Dec 2, 2024
@dweindl dweindl merged commit 23e8045 into AMICI-dev:develop Dec 2, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

irreproducible segfault in python/examples/example_splines_swameye/ExampleSplinesSwameye2003.ipynb
2 participants