Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jax export #1861

Merged
merged 94 commits into from
Nov 19, 2024
Merged
Changes from 1 commit
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
328d462
basic prototype
FFroehlich Aug 25, 2022
ffa5afb
Merge branch 'develop' into jax_export
FFroehlich Aug 26, 2022
d4f8552
add dimerization example, add second order code, refactor jit
FFroehlich Aug 26, 2022
d37a850
remove equinox dependency, list dependencies
FFroehlich Aug 26, 2022
ff37c7e
make jax optional
FFroehlich Aug 26, 2022
c3a77f7
Merge branch 'develop' into jax_export
FFroehlich Aug 26, 2022
7cd8553
support conservation laws
FFroehlich Aug 26, 2022
5177ad7
fixup
FFroehlich Aug 26, 2022
5612cfc
fix jit nesting
FFroehlich Aug 26, 2022
2dd0377
use vmap for vectorization
FFroehlich Aug 26, 2022
e9bd14f
fixups
FFroehlich Aug 26, 2022
bbb5246
add multithreaded simulation runner
FFroehlich Aug 26, 2022
9bd1004
fix my
FFroehlich Aug 26, 2022
1b06c24
Merge branch 'develop' into jax_export
FFroehlich Sep 9, 2022
599aa71
fixes
FFroehlich Sep 13, 2022
51812d6
merge
FFroehlich Apr 10, 2024
3fbd17a
fixup merge
FFroehlich Apr 10, 2024
5974d47
fix install
FFroehlich Apr 10, 2024
37cdc81
actually generate code
FFroehlich Apr 10, 2024
9e6a0ff
fix
FFroehlich Apr 10, 2024
22b2b38
fix
FFroehlich Apr 10, 2024
48a2e49
add better default coefficients, fix jax
FFroehlich Apr 10, 2024
481216d
ignore fujita in jax
FFroehlich Apr 10, 2024
85b8173
ignore smith
FFroehlich Apr 10, 2024
b213adb
optimize & fix bachmann
FFroehlich Apr 11, 2024
a1f37b7
fix import/wokflow
FFroehlich Apr 11, 2024
e09bb2f
Update __init__.template.py
FFroehlich Apr 12, 2024
d8d1900
fix jax imports
FFroehlich Apr 12, 2024
c24fe6b
Update setup.cfg
FFroehlich Apr 12, 2024
1ec591c
add preequilibration support
FFroehlich Apr 12, 2024
aebe07c
fix jax tests
FFroehlich Apr 13, 2024
4125c51
add filterwarning
FFroehlich Apr 14, 2024
8143cc2
fix parameter transformation
FFroehlich Apr 14, 2024
781bb3b
Merge branch 'develop' into jax_export
FFroehlich Oct 19, 2024
81e2aeb
reenable ruff format
FFroehlich Oct 19, 2024
c01f707
post merge cleanup
FFroehlich Oct 19, 2024
a5d356a
"fix" splines
FFroehlich Oct 19, 2024
9a021cf
Update .pre-commit-config.yaml
FFroehlich Oct 19, 2024
a02d215
Merge branch 'develop' into jax_export
FFroehlich Oct 19, 2024
50193d8
force optimistix 0.0.9
FFroehlich Oct 21, 2024
d6c5bcd
Merge branch 'jax_export' of https://github.com/AMICI-dev/AMICI into …
FFroehlich Oct 21, 2024
7faae32
add support for heavyside functions
FFroehlich Oct 21, 2024
907acb7
cleanup & actually run tests
FFroehlich Oct 21, 2024
82a01ba
simply tests + add support for non-dynamic simulation in jax
FFroehlich Oct 22, 2024
7c3aef9
Merge branch 'develop' into jax_export
FFroehlich Oct 23, 2024
c548c93
fix for NONCONST_CLS
FFroehlich Oct 24, 2024
7c27a21
fix petab path
FFroehlich Oct 24, 2024
b84dbdb
Merge branch 'develop' into jax_export
FFroehlich Oct 24, 2024
37b9329
Merge branch 'develop' into jax_export
FFroehlich Oct 24, 2024
956b0a6
fixup merge
FFroehlich Oct 24, 2024
2f3834d
support postequilibration
FFroehlich Oct 25, 2024
5366632
fixup
FFroehlich Oct 25, 2024
5a86f4c
fix
FFroehlich Oct 25, 2024
480b75a
fix gradients
FFroehlich Oct 25, 2024
8b9c10a
fix hessian
FFroehlich Oct 25, 2024
7dc81ac
Update test_petab_benchmark.py
FFroehlich Oct 25, 2024
866c811
Merge branch 'develop' into jax_export
FFroehlich Oct 27, 2024
02a1272
skip smith in jax
FFroehlich Oct 27, 2024
51bd18c
exclude more models
FFroehlich Oct 27, 2024
c7c5d4b
refactor: remove use of edatas
FFroehlich Nov 9, 2024
a514deb
update template
FFroehlich Nov 9, 2024
498681a
Update .pre-commit-config.yaml
FFroehlich Nov 9, 2024
4a5e7d2
Merge branch 'develop' into jax_export
FFroehlich Nov 11, 2024
f745be0
fix python jax tests
FFroehlich Nov 12, 2024
a64f89b
simplify petab interface
FFroehlich Nov 12, 2024
7292451
add parameter values to model class
FFroehlich Nov 12, 2024
da02106
refactor parameter mapping
FFroehlich Nov 12, 2024
a46e65d
refactor & simplify
FFroehlich Nov 12, 2024
404d82e
refsctor
FFroehlich Nov 16, 2024
e399f4c
update template
FFroehlich Nov 16, 2024
eaae778
Update .pre-commit-config.yaml
FFroehlich Nov 16, 2024
d79cfc1
refactor fix test
FFroehlich Nov 16, 2024
94aa679
Update petab.py
FFroehlich Nov 16, 2024
b129c86
fixups
FFroehlich Nov 17, 2024
9b6a62b
fixup
FFroehlich Nov 17, 2024
74cd498
add documentation and typing
FFroehlich Nov 17, 2024
d94714b
add runtime typechecks to jax tests
FFroehlich Nov 17, 2024
0a9fcdf
add coverage from benchmark tests
FFroehlich Nov 17, 2024
186805c
add api versioning and reenable jit compilation
FFroehlich Nov 17, 2024
250f9dd
review comments
FFroehlich Nov 18, 2024
dc4992e
use temporary directories
FFroehlich Nov 18, 2024
d547509
fix doc
FFroehlich Nov 18, 2024
82bfe31
Update test_jax.py
FFroehlich Nov 18, 2024
a010803
don't generate code if jax/diffrax not available
FFroehlich Nov 18, 2024
d9ae05e
Merge branch 'develop' into jax_export
FFroehlich Nov 18, 2024
f7c2c10
add example
FFroehlich Nov 19, 2024
5dc8735
fix doc
FFroehlich Nov 19, 2024
784ab2c
fix notebook symlink
FFroehlich Nov 19, 2024
d528168
update notebook
FFroehlich Nov 19, 2024
24d8c09
Update ExampleJaxPEtab.ipynb
FFroehlich Nov 19, 2024
5393e6c
Update ExampleJaxPEtab.ipynb
FFroehlich Nov 19, 2024
a22f099
fix compilation issue
FFroehlich Nov 19, 2024
a585414
Merge branch 'develop' into jax_export
FFroehlich Nov 19, 2024
c242b15
fix
FFroehlich Nov 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
exclude more models
FFroehlich committed Oct 27, 2024
commit 51bd18cac0314d6dbd3c8b39aee660641a4d4d36
9 changes: 8 additions & 1 deletion tests/benchmark-models/test_petab_benchmark.py
Original file line number Diff line number Diff line change
@@ -262,7 +262,14 @@ def benchmark_problem(request):
def test_jax_llh(benchmark_problem):
FFroehlich marked this conversation as resolved.
Show resolved Hide resolved
problem_id, petab_problem, amici_model = benchmark_problem

if problem_id == "Smith_BMCSystBiol2013":
if problem_id in (
"Bachmann_MSB2011",
"Isensee_JCB2018",
"Lucarelli_CellSystems2018",
"SalazarCavazos_MBoC2020",
"Smith_BMCSystBiol2013",
):
# confirmed to work 27/10/2024 but experienced high local runtime (M2 MBA, >30s)
pytest.skip("Excluded from JAX check due to excessive runtime")

amici_solver = amici_model.getSolver()

Unchanged files with check annotations Beta

)(p, pscale)
def _preeq(self, p, k):
x0 = self.x_solver(self.x0(p, k))
tcl = self.tcl(x0, p, k)
return self._eq(p, k, tcl, x0)

Check warning on line 98 in python/sdist/amici/jax.py

Codecov / codecov/patch

python/sdist/amici/jax.py#L96-L98

Added lines #L96 - L98 were not covered by tests
def _posteq(self, p, k, x, tcl):
return self._eq(p, k, tcl, x)

Check warning on line 101 in python/sdist/amici/jax.py

Codecov / codecov/patch

python/sdist/amici/jax.py#L101

Added line #L101 was not covered by tests
def _eq(self, p, k, tcl, x0):
sol = diffrax.diffeqsolve(

Check warning on line 104 in python/sdist/amici/jax.py

Codecov / codecov/patch

python/sdist/amici/jax.py#L104

Added line #L104 was not covered by tests
self.term,
self.solver,
args=(p, k, tcl),
max_steps=self.maxsteps,
event=diffrax.Event(cond_fn=diffrax.steady_state_event()),
)
return sol.ys

Check warning on line 116 in python/sdist/amici/jax.py

Codecov / codecov/patch

python/sdist/amici/jax.py#L116

Added line #L116 was not covered by tests
def _solve(self, ts, p, k, x0, checkpointed):
tcl = self.tcl(x0, p, k)
# Pre-equilibration
if k_preeq.shape[0] > 0:
x0 = self._preeq(ps, k_preeq)

Check warning on line 169 in python/sdist/amici/jax.py

Codecov / codecov/patch

python/sdist/amici/jax.py#L169

Added line #L169 was not covered by tests
else:
x0 = self.x0(ps, k)
ts_dyn, ps, k, x0, checkpointed=checkpointed
)
else:
x = tuple(

Check warning on line 179 in python/sdist/amici/jax.py

Codecov / codecov/patch

python/sdist/amici/jax.py#L179

Added line #L179 was not covered by tests
jnp.array([x0_i] * len(ts_dyn)) for x0_i in self.x_solver(x0)
)
tcl = self.tcl(x0, ps, k)
stats = None

Check warning on line 183 in python/sdist/amici/jax.py

Codecov / codecov/patch

python/sdist/amici/jax.py#L182-L183

Added lines #L182 - L183 were not covered by tests
# Post-equilibration
if len(ts) > len(ts_dyn):
if len(ts_dyn) > 0:
x_final = tuple(x_i[-1] for x_i in x)

Check warning on line 188 in python/sdist/amici/jax.py

Codecov / codecov/patch

python/sdist/amici/jax.py#L187-L188

Added lines #L187 - L188 were not covered by tests
else:
x_final = self.x_solver(x0)
x_posteq = self._posteq(ps, k, x_final, tcl)
x_posteq = tuple(

Check warning on line 192 in python/sdist/amici/jax.py

Codecov / codecov/patch

python/sdist/amici/jax.py#L190-L192

Added lines #L190 - L192 were not covered by tests
jnp.array([x0_i] * (len(ts) - len(ts_dyn)))
for x0_i in x_posteq
)
if len(ts_dyn) > 0:
x = tuple(

Check warning on line 197 in python/sdist/amici/jax.py

Codecov / codecov/patch

python/sdist/amici/jax.py#L196-L197

Added lines #L196 - L197 were not covered by tests
jnp.concatenate((x_i, x_posteq_i), axis=0)
for x_i, x_posteq_i in zip(x, x_posteq)
)
else:
x = x_posteq

Check warning on line 202 in python/sdist/amici/jax.py

Codecov / codecov/patch

python/sdist/amici/jax.py#L202

Added line #L202 was not covered by tests
obs = self._obs(ts, x, ps, k, tcl)
my_r = my.reshape((len(ts), -1))
elif field not in ["sllh", "s2llh"]:
rdata_kwargs[field] = np.asarray(rdata_kwargs[field]).T
if rdata_kwargs[field].ndim == 1:
rdata_kwargs[field] = np.expand_dims(

Check warning on line 319 in python/sdist/amici/jax.py

Codecov / codecov/patch

python/sdist/amici/jax.py#L319

Added line #L319 was not covered by tests
rdata_kwargs[field], 1
)
self.run_simulation, sensitivity_order=sensitivity_order
)
if num_threads > 1:
with ThreadPoolExecutor(max_workers=num_threads) as pool:
results = pool.map(fun, edatas)

Check warning on line 336 in python/sdist/amici/jax.py

Codecov / codecov/patch

python/sdist/amici/jax.py#L335-L336

Added lines #L335 - L336 were not covered by tests
else:
results = map(fun, edatas)
return list(results)
code = re.sub(r"numpy\.", r"jnp.", code)
return code
except TypeError as e:

Check warning on line 20 in python/sdist/amici/jaxcodeprinter.py

Codecov / codecov/patch

python/sdist/amici/jaxcodeprinter.py#L20

Added line #L20 was not covered by tests
raise ValueError(
f'Encountered unsupported function in expression "{expr}"'
) from e