Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitivities for AlgebraicRule models #2101

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented May 22, 2023

Support for AlgebraicRules was added in #2017. Sensitivity analysis is not yet supported.

Looking for volunteers to finish that.

Test case: pytest tests/testSBMLSuite.py::test_sbml_testsuite_case[00039] (and many others in this suite)

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #2101 (afdc731) into develop (7d161a6) will decrease coverage by 0.22%.
The diff coverage is 5.26%.

❗ Current head afdc731 differs from pull request most recent head 74b9d3d. Consider uploading reports for the commit 74b9d3d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2101      +/-   ##
===========================================
- Coverage    76.67%   76.45%   -0.22%     
===========================================
  Files           82       81       -1     
  Lines        14939    14864      -75     
===========================================
- Hits         11454    11364      -90     
- Misses        3485     3500      +15     
Flag Coverage Δ
cpp 73.44% <5.26%> (-0.12%) ⬇️
petab 54.40% <ø> (+0.16%) ⬆️
python 76.82% <ø> (-0.47%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/model_dae.cpp 30.35% <5.26%> (-1.75%) ⬇️

... and 10 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requesting sensitivities for algebraic equations breaks simulation
1 participant