-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setuptools<64 restriction #2180
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2180 +/- ##
===========================================
- Coverage 76.59% 76.57% -0.03%
===========================================
Files 82 82
Lines 15000 15004 +4
===========================================
Hits 11489 11489
- Misses 3511 3515 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It seems it was due to a change in temporary build directories. Previously:
Now:
Can we easily override the build directory? Needs further investigation...
-> check for pip/setuptools options TODO: try https://stackoverflow.com/a/66163350 |
We had to require setuptools<64 because it change its temporary build directory from a known path to a randomly named temporary directory. However, setuptools<64 doesn't work with for Python3.12 (#2179). Therefore, this adds an option to change the setuptools temporary build directory, so we have those temp files in a known path for coverage analysis. Not meant to be used by users.