Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake cmake_minimum_required deprecation warning #2183

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix CMake cmake_minimum_required deprecation warning #2183

merged 1 commit into from
Oct 30, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 27, 2023

Fixes

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

@dweindl
Fix CMake cmake_minimum_required deprecation warning
bee8e6a 
Fixes
```
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
```
@dweindl dweindl requested a review from a team as a code owner October 27, 2023 15:25
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #2183 (bee8e6a) into develop (c038ff5) will decrease coverage by 22.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2183       +/-   ##
============================================
- Coverage    76.64%   53.93%   -22.71%     
============================================
  Files           82       34       -48     
  Lines        14979     5625     -9354     
============================================
- Hits         11481     3034     -8447     
+ Misses        3498     2591      -907
Flag Coverage Δ
cpp ?
petab 53.93% <ø> (ø)
python ?
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 66 files with indirect coverage changes

@dweindl dweindl merged commit fb2a101 into develop Oct 30, 2023
14 of 16 checks passed
@dweindl dweindl deleted the fix_cmake_depr branch October 30, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweindl @FFroehlich