Easier access to timepoints via ExpDataView #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExpDataView provides convenient access to measurements and the like as numpy arrays. However, accessing the associated timepoints is currently only possible via `ExpDataView(...)._swigptr.ts_` which returns an amici.amici.DoubleVector. That's awkward. Now: ```python amici.ExpDataView(amici.ExpData(1, 2, 3, [4, 5, 6])).ts Out[3]: array([4., 5., 6.]) ``` Resolves #2191
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2193 +/- ##
===========================================
- Coverage 77.45% 76.62% -0.84%
===========================================
Files 82 82
Lines 15004 15005 +1
===========================================
- Hits 11621 11497 -124
- Misses 3383 3508 +125
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Nov 15, 2023
dweindl
added a commit
that referenced
this pull request
Nov 15, 2023
ExpDataView provides convenient access to measurements and the like as numpy arrays. However, accessing the associated timepoints is currently only possible via `ExpDataView(...)._swigptr.ts_` which returns an amici.amici.DoubleVector. That's awkward. Now: ```python amici.ExpDataView(amici.ExpData(1, 2, 3, [4, 5, 6])).ts Out[3]: array([4., 5., 6.]) ``` Resolves #2191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpDataView provides convenient access to measurements and the like as numpy arrays. However, accessing the associated timepoints is currently only possible via
ExpDataView(...)._swigptr.ts_which returns an amici.amici.DoubleVector. That's awkward.Now:
Resolves #2191