Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deepcopy for ExpData(View) #2196

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Enable deepcopy for ExpData(View) #2196

merged 4 commits into from
Nov 15, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 15, 2023

Fixes a bug in SwigPtrView.__deepcopy__ which did not produce a deep copy.

Add SwigPtrView.__eq__ to allow for comparison. The view objects are considered equal if the underlying viewed objects are equal.

Fixes #2189.

Wasn't automatically handled by swig for unclear reasons. Works now. Fixes #2190.
Fixes a bug in SwigPtrView.__deepcopy__ which did not produce a deep copy.

Add SwigPtrView.__eq__ to allow for comparison. The view objects are considered
equal if the underlying viewed objects are equal.

Fixes #2189.
@dweindl dweindl requested a review from a team as a code owner November 15, 2023 13:39
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #2196 (f82b1b5) into develop (187362a) will increase coverage by 0.01%.
The diff coverage is 80.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2196      +/-   ##
===========================================
+ Coverage    76.62%   76.63%   +0.01%     
===========================================
  Files           82       82              
  Lines        15008    15012       +4     
===========================================
+ Hits         11500    11505       +5     
+ Misses        3508     3507       -1     
Flag Coverage Δ
cpp 73.53% <ø> (-0.04%) ⬇️
petab 53.80% <20.00%> (-0.03%) ⬇️
python 77.23% <80.00%> (+0.08%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/numpy.py 85.98% <80.00%> (+4.42%) ⬆️

... and 1 file with indirect coverage changes

Base automatically changed from expdata_equality to develop November 15, 2023 16:13
@dweindl dweindl merged commit 1726f43 into develop Nov 15, 2023
18 of 19 checks passed
@dweindl dweindl deleted the deepcopy_edata branch November 15, 2023 18:31
@dweindl dweindl linked an issue Nov 20, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable deepcopy for ExpData(View)
2 participants