GHA: Modularize actions (apt dependencies, sonar tools) #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2197 +/- ##
===========================================
- Coverage 76.61% 76.60% -0.01%
===========================================
Files 82 82
Lines 15008 15008
===========================================
- Hits 11498 11497 -1
- Misses 3510 3511 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
dweindl
changed the title
FFroehlich
approved these changes
Nov 16, 2023
| # install amici dependencies | ||
| - name: Install apt dependencies | ||
| uses: ./.github/actions/install-apt-dependencies | ||
|
|
||
| - name: apt | ||
| run: | | ||
| sudo apt-get update \ |
There was a problem hiding this comment.
Takes only about 1s to run it a second time, I'd leave it here to keep it's safer to shuffle those steps around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRY, use composite actions. More readable + more maintainable.