GHA: Cleanup custom swig usage #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dweindl
commented
Nov 15, 2023
dweindl
commented
- Previously the newest swig was downloaded and built, but not used because of a wrong path. Fixed here.
- Make scripts/downloadAndBuildSwig.sh accept a version number argument
- Use composite action to make it more maintainable and avoid issues as fixed above
* Previously the newest swig was downloaded and built, but not used because of a wrong path. Fixed here. * Make scripts/downloadAndBuildSwig.sh accept a version number argument * Use composite action to make it more maintainable and avoid issues as fixed above
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2200 +/- ##
===========================================
+ Coverage 76.59% 76.63% +0.03%
===========================================
Files 82 82
Lines 15012 15012
===========================================
+ Hits 11499 11505 +6
+ Misses 3513 3507 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
FFroehlich
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.