Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Fix OpenMP not found on macos #2207

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 20, 2023

  • Ensure cmake can find OpenMP
  • Assert that amici was compiled with OpenMP support
  • Update installation guide

Fixes #2182

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #2207 (8aad4a9) into develop (8b836ae) will decrease coverage by 22.73%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2207       +/-   ##
============================================
- Coverage    76.53%   53.80%   -22.73%     
============================================
  Files           82       34       -48     
  Lines        15012     5652     -9360     
============================================
- Hits         11489     3041     -8448     
+ Misses        3523     2611      -912     
Flag Coverage Δ
cpp ?
cpp_python ?
petab 53.80% <ø> (ø)
python ?
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 66 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review November 20, 2023 13:54
@dweindl dweindl requested a review from a team as a code owner November 20, 2023 13:54
@dweindl dweindl linked an issue Nov 20, 2023 that may be closed by this pull request
3 tasks
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brew link openmp and brew link boost would also work but adds those paths globally. $(brew --prefix) won't work with non-default install directories.

@dweindl
Copy link
Member Author

dweindl commented Nov 21, 2023

brew link openmp and brew link boost would also work but adds those paths globally.

Okay, will add that to installation guide.

$(brew --prefix) won't work with non-default install directories.

I am not really familiar with brew. Do you mean there are cases where brew install something will install the package somewhere else than $(brew --prefix)? Or only if other options are passed?

@FFroehlich
Copy link
Member

$(brew --prefix) won't work with non-default install directories.

I am not really familiar with brew. Do you mean there are cases where brew install something will install the package somewhere else than $(brew --prefix)? Or only if other options are passed?

thought it was possible, but it's actually not. $(brew --prefix) should always work.

@dweindl dweindl merged commit 4f6e829 into AMICI-dev:develop Nov 21, 2023
8 of 9 checks passed
@dweindl dweindl deleted the fix_2182_openmp branch November 21, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHA: OpenMP not found on macos
2 participants