Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: PEtab code to sub-package (cont.) #2211

Merged
merged 14 commits into from
Dec 1, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 21, 2023

Continuation of #2205

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #2211 (f87a21a) into develop (67c9ca9) will decrease coverage by 22.73%.
The diff coverage is 78.45%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2211       +/-   ##
============================================
- Coverage    76.50%   53.77%   -22.73%     
============================================
  Files           86       43       -43     
  Lines        15019     5668     -9351     
============================================
- Hits         11490     3048     -8442     
+ Misses        3529     2620      -909     
Flag Coverage Δ
cpp ?
cpp_python ?
petab 53.77% <78.45%> (+0.02%) ⬆️
python ?
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/__main__.py 0.00% <ø> (ø)
python/sdist/amici/petab/cli/import_petab.py 0.00% <ø> (ø)
python/sdist/amici/petab/simulator.py 100.00% <100.00%> (ø)
python/sdist/amici/petab_util.py 0.00% <ø> (ø)
python/tests/test_petab_import.py 100.00% <100.00%> (ø)
python/tests/test_petab_objective.py 100.00% <ø> (ø)
python/tests/test_petab_simulate.py 100.00% <ø> (ø)
python/sdist/amici/parameter_mapping.py 0.00% <0.00%> (ø)
python/sdist/amici/petab_objective.py 0.00% <0.00%> (-92.71%) ⬇️
python/sdist/amici/petab_simulate.py 0.00% <0.00%> (-100.00%) ⬇️
... and 5 more

... and 65 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review November 22, 2023 18:43
@dweindl dweindl requested a review from a team as a code owner November 22, 2023 18:43
@dweindl
Copy link
Member Author

dweindl commented Nov 29, 2023

ping @FFroehlich

@dweindl dweindl self-assigned this Nov 29, 2023
@dweindl dweindl merged commit a41c906 into AMICI-dev:develop Dec 1, 2023
9 of 10 checks passed
@dweindl dweindl deleted the refactor_petab branch December 1, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants