Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Fix actions for PRs from forks #2219

Merged
merged 8 commits into from
Dec 3, 2023
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 1, 2023

* run codecov only on pull requests
* trigger relevant actions on `pull_request` instead of only on `push`

Closes AMICI-dev#2218
@dweindl dweindl requested a review from a team as a code owner December 1, 2023 10:45
@dweindl dweindl linked an issue Dec 1, 2023 that may be closed by this pull request
@dweindl dweindl self-assigned this Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #2219 (04fdb18) into develop (06f6217) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2219      +/-   ##
===========================================
- Coverage    76.50%   76.46%   -0.04%     
===========================================
  Files           91       91              
  Lines        15034    15034              
===========================================
- Hits         11502    11496       -6     
- Misses        3532     3538       +6     
Flag Coverage Δ
cpp 73.01% <ø> (-0.07%) ⬇️
cpp_python 37.03% <ø> (ø)
petab 53.77% <ø> (ø)
python 77.13% <ø> (ø)
sbmlsuite ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit dff4ec3 into AMICI-dev:develop Dec 3, 2023
24 of 25 checks passed
@dweindl dweindl deleted the gha_fork branch December 3, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix running github actions from forks
2 participants