Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildAmici.sh: Only try installing numpy if not yet available #2230

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 11, 2023

Makes buildAmici.sh work with system-python. Before, it would fail if we don't have write permissions to system-packages even if numpy was already installed.

Makes buildAmici.sh work with system-python. Before, it would fail if we don't have write permissions to system-packages even if numpy was already installed.
@dweindl dweindl requested a review from a team as a code owner December 11, 2023 07:27
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #2230 (427c2fd) into develop (ecbae3f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2230   +/-   ##
========================================
  Coverage    76.64%   76.64%           
========================================
  Files           91       91           
  Lines        15109    15109           
========================================
  Hits         11580    11580           
  Misses        3529     3529           
Flag Coverage Δ
cpp 73.11% <ø> (ø)
cpp_python 37.08% <ø> (ø)
petab 53.74% <ø> (ø)
python 77.44% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 check against some minimum version?

@dweindl
Copy link
Member Author

dweindl commented Dec 12, 2023

check against some minimum version?

Wouldn't hurt, but it's a bit of a pain. We'll either have to hardcode minimum numpy versions for different python versions and platforms here, or we need to parse the constraints from pyproject.toml.
It would be easiest if pip would support installing only build-dependencies, but that's not possible unfortunately.

I would rather address that some other time. This PR doesn't really change anything in that respect. Before this change, numpy wouldn't have been upgraded either. With system-pip, pip install numpy would already fail before even checking if there is any numpy installed.

@dweindl dweindl merged commit 0bc2f2a into AMICI-dev:develop Dec 12, 2023
19 checks passed
@dweindl dweindl deleted the pip_np branch December 12, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants