Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PEtab benchmark collection path via $BENCHMARK_COLLECTION #2236

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 13, 2023

More convenient to use locally. Avoids having multiple copies of the PEtab benchmark collection lying around for different projects.

More convenient to use locally. Avoids having multiple copies of the PEtab benchmark collection lying around for different projects.
@dweindl dweindl requested a review from a team as a code owner December 13, 2023 10:55
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #2236 (ef61b08) into develop (93885e3) will decrease coverage by 0.14%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2236      +/-   ##
===========================================
- Coverage    76.77%   76.64%   -0.14%     
===========================================
  Files           91       91              
  Lines        15109    15109              
===========================================
- Hits         11600    11580      -20     
- Misses        3509     3529      +20     
Flag Coverage Δ
cpp 73.11% <ø> (-0.08%) ⬇️
cpp_python 37.08% <ø> (ø)
petab 53.74% <ø> (ø)
python 77.44% <ø> (-0.24%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@dweindl dweindl merged commit eba9557 into AMICI-dev:develop Dec 13, 2023
18 of 19 checks passed
@dweindl dweindl deleted the benchmark_dir branch January 2, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants