Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation after PEtab refactoring #2252

Merged
merged 7 commits into from
Jan 2, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 20, 2023

  • Fixed missing documentation in deprecated modules
  • Added deprecation notices in sphinx docs
  • Fixes some python int/enum sphinx issues
  • Remove methods inherited from builtins from docs

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0cc43f9) 76.64% compared to head (367115b) 76.61%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2252      +/-   ##
===========================================
- Coverage    76.64%   76.61%   -0.04%     
===========================================
  Files           91       91              
  Lines        15016    15021       +5     
===========================================
- Hits         11509    11508       -1     
- Misses        3507     3513       +6     
Flag Coverage Δ
cpp 73.09% <ø> (-0.03%) ⬇️
cpp_python 37.08% <ø> (ø)
petab 53.73% <14.28%> (-0.04%) ⬇️
python 77.91% <14.28%> (-0.06%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/petab/__init__.py 100.00% <ø> (ø)
python/sdist/amici/petab/petab_import.py 66.66% <ø> (ø)
python/sdist/amici/petab/pysb_import.py 52.72% <ø> (ø)
python/sdist/amici/petab/simulations.py 92.78% <100.00%> (+0.07%) ⬆️
python/sdist/amici/parameter_mapping.py 0.00% <0.00%> (ø)
python/sdist/amici/petab_objective.py 0.00% <0.00%> (ø)
python/sdist/amici/petab_simulate.py 0.00% <0.00%> (ø)
python/sdist/amici/petab_util.py 0.00% <0.00%> (ø)
python/sdist/amici/swig.py 13.51% <0.00%> (ø)

... and 3 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review December 20, 2023 13:29
@dweindl dweindl requested a review from a team as a code owner December 20, 2023 13:29
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@dweindl dweindl enabled auto-merge January 2, 2024 10:01
@dweindl dweindl disabled auto-merge January 2, 2024 11:32
@dweindl dweindl merged commit 409ae3d into AMICI-dev:develop Jan 2, 2024
17 of 19 checks passed
@dweindl dweindl deleted the refactor_petab branch January 2, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants