Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Solver copyctor issues with swig4.2 #2276

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 24, 2024

Closes #2275

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (786b586) 77.16% compared to head (a918a7a) 77.16%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2276   +/-   ##
========================================
  Coverage    77.16%   77.16%           
========================================
  Files           94       94           
  Lines        15089    15089           
========================================
  Hits         11644    11644           
  Misses        3445     3445           
Flag Coverage Δ
cpp 74.02% <ø> (ø)
cpp_python 37.36% <ø> (ø)
petab 54.00% <ø> (ø)
python 76.98% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@dweindl dweindl marked this pull request as ready for review January 24, 2024 15:15
@dweindl dweindl requested a review from a team as a code owner January 24, 2024 15:15
@dweindl dweindl merged commit 35cd14e into AMICI-dev:develop Jan 24, 2024
20 checks passed
@dweindl dweindl deleted the fix_swig42 branch January 24, 2024 18:29
@dweindl dweindl linked an issue Jan 31, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails with SWIG 4.2
2 participants