Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ENABLE_AMICI_DEBUGGING=TRUE not working with MSVC #2296

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 20, 2024

Fixes

cl : Command line warning D9002 : ignoring unknown option '-O0'
cl : Command line warning D9002 : ignoring unknown option '-g'

see also https://learn.microsoft.com/en-us/cpp/build/reference/debug-generate-debug-info?view=msvc-170

Fixes #2228

@dweindl dweindl self-assigned this Feb 20, 2024
@dweindl dweindl linked an issue Feb 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24685a3) 77.75% compared to head (8a6d91d) 77.75%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2296   +/-   ##
========================================
  Coverage    77.75%   77.75%           
========================================
  Files          318      318           
  Lines        20511    20511           
  Branches      1436     1436           
========================================
  Hits         15948    15948           
  Misses        4560     4560           
  Partials         3        3           
Flag Coverage Δ
cpp 73.53% <ø> (ø)
cpp_python 33.99% <ø> (ø)
petab 36.40% <ø> (ø)
python 72.30% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@dweindl dweindl marked this pull request as ready for review February 20, 2024 11:18
@dweindl dweindl requested a review from a team as a code owner February 20, 2024 11:18
@dweindl dweindl merged commit 3573131 into AMICI-dev:develop Feb 20, 2024
20 checks passed
@dweindl dweindl deleted the fix_2228_msvc_dbg branch February 20, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENABLE_AMICI_DEBUGGING=TRUE not working with MSVC
2 participants