Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unnecessary toposorting in DEModel._collect_heaviside_roots #2299

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 20, 2024

Sorting is only required if roots have been found. Most often this will not be the case. Only sort when necessary.

Sorting is only required if roots have been found. Most often this will not be the case.
Only sort when necessary.
@dweindl dweindl self-assigned this Feb 20, 2024
@dweindl dweindl marked this pull request as ready for review February 20, 2024 20:45
@dweindl dweindl requested a review from a team as a code owner February 20, 2024 20:45
@dweindl dweindl enabled auto-merge February 20, 2024 20:45
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3573131) 77.75% compared to head (7e7fb90) 77.75%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2299   +/-   ##
========================================
  Coverage    77.75%   77.75%           
========================================
  Files          318      318           
  Lines        20511    20513    +2     
  Branches      1436     1436           
========================================
+ Hits         15948    15950    +2     
  Misses        4560     4560           
  Partials         3        3           
Flag Coverage Δ
cpp 73.53% <100.00%> (+<0.01%) ⬆️
cpp_python 34.00% <100.00%> (+<0.01%) ⬆️
petab 36.38% <100.00%> (-0.02%) ⬇️
python 72.31% <100.00%> (+<0.01%) ⬆️
sbmlsuite ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/de_export.py 91.77% <100.00%> (+0.01%) ⬆️

@dweindl dweindl added this pull request to the merge queue Feb 21, 2024
Merged via the queue into AMICI-dev:develop with commit 74d4e1f Feb 21, 2024
26 checks passed
@dweindl dweindl deleted the fix_extra_toposort branch February 22, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants