Release 0.22.0 #2309
Merged
Release 0.22.0 #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* support "do not compile" for petab problems * rewrite * do not pass new kwarg to sbml2amici
Submitting coverage results to codecov from push-triggered actions from forks will result in missing-token errors. Therefore, skip codecov submission in those cases. Reverts some removals from AMICI-dev#2284.
Closes AMICI-dev#2288 Fixes: 1. > Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/setup-qemu-action@v2, docker/setup-buildx-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. 2. Prevent errors on fork actions: > Run elgohr/Publish-Docker-Github-Action@v4 Run $GITHUB_ACTION_PATH/entrypoint.sh Unable to find the username. Did you set with.username? Either check for organization=amici-dev, or whether the username is set.
To be consistent with all other model components.
Fixes ``` cl : Command line warning D9002 : ignoring unknown option '-O0' cl : Command line warning D9002 : ignoring unknown option '-g' ``` see also https://learn.microsoft.com/en-us/cpp/build/reference/debug-generate-debug-info?view=msvc-170 Fixes AMICI-dev#2228
* Fix MANIFEST.in Fixes `warning: manifest_maker: MANIFEST.in, line 13: path '**/build/' cannot end with '/'` e.g. https://github.com/AMICI-dev/AMICI/actions/runs/7970974169/job/21759690743?pr=2296#step:14:163 * .. * ..
…MICI-dev#2299) Sorting is only required if roots have been found. Most often this will not be the case. Only sort when necessary.
Fixes potentially incorrect simulation results when using rateOf in `w` where the rates depend on `w`. Fixes AMICI-dev#2290
Remove an extraneous call to Model::fdwdx, the result of which will be overridden without use by Model_ODE::fJSparse.
Add a `.gitignore` file to the amici-generated model directory to exclude the auto-generated files from version control. Closes AMICI-dev#2300.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2309 +/- ##
==========================================
+ Coverage 77.78% 77.95% +0.17%
==========================================
Files 318 318
Lines 20511 20534 +23
Branches 1436 1436
==========================================
+ Hits 15954 16008 +54
+ Misses 4554 4523 -31
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.