SBML import: Evaluate initial assignments #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evaluate initial assignments to parameters to determine whether the targets are amici parameters or expressions. Related to AMICI-dev#2304.
FFroehlich
approved these changes
Mar 6, 2024
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Mar 13, 2024
* Ensure initial state parameters are always fixed parameters * Ensure initial concentration for preequilibration and simulation are both set in both phases to avoid NaN issues * Fix initialAssignment handling during PEtab import (missed in AMICI-dev#2359)
dweindl
added a commit
that referenced
this pull request
Mar 18, 2024
* Ensure initial state parameters are always fixed parameters * Ensure initial concentration for preequilibration and simulation are both set in both phases to avoid NaN issues * Fix initialAssignment handling during PEtab import (missed in #2359)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluate initial assignments to parameters to determine whether the targets are amici parameters or expressions. Related to #2304.
For example, it the initial assignment is
log(10), this should still be a parameter instead of an expression, butsympy.log(10).is_Numberwill beFalse.