Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log stacktraces only in debug mode #2366

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 7, 2024

Closes #2186

@dweindl dweindl requested a review from a team as a code owner March 7, 2024 13:17
@dweindl dweindl self-assigned this Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.40%. Comparing base (8d65524) to head (2cacf0a).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2366      +/-   ##
===========================================
- Coverage    77.66%   75.40%   -2.26%     
===========================================
  Files          324      324              
  Lines        20825    20824       -1     
  Branches      1454     1454              
===========================================
- Hits         16174    15703     -471     
- Misses        4648     4785     +137     
- Partials         3      336     +333     
Flag Coverage Δ
cpp ?
cpp_python 34.25% <ø> (-0.01%) ⬇️
petab 36.86% <ø> (-0.01%) ⬇️
python 72.22% <ø> (-0.01%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/amici.cpp 76.99% <ø> (-4.43%) ⬇️

... and 26 files with indirect coverage changes

@dweindl dweindl merged commit c43ce3b into AMICI-dev:develop Mar 7, 2024
18 of 20 checks passed
@dweindl dweindl deleted the stacktrace_dbg branch March 7, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants