Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Fix headings in ExampleJax #2371

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 7, 2024

To properly integrate into our sphinx docs.
@dweindl dweindl requested a review from a team as a code owner March 7, 2024 15:51
@dweindl
Copy link
Member Author

dweindl commented Mar 7, 2024

Hm, there is documentation/ExampleJax.ipynb and python/examples/example_jax/ExampleJax.ipynb. The former should be a symlink to the latter, but it is not. Seems like the two have diverged. Looks like those were two independent files from the beginning (#1996).

@FFroehlich: can you please check which one to keep?

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.70%. Comparing base (7a920e2) to head (1fc4f8f).

❗ Current head 1fc4f8f differs from pull request most recent head 42e8f5b. Consider uploading reports for the commit 42e8f5b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2371   +/-   ##
========================================
  Coverage    77.70%   77.70%           
========================================
  Files          324      324           
  Lines        20864    20864           
  Branches      1458     1458           
========================================
  Hits         16213    16213           
  Misses        4648     4648           
  Partials         3        3           
Flag Coverage Δ
cpp 73.48% <ø> (ø)
cpp_python 34.23% <ø> (ø)
petab 36.82% <ø> (ø)
python 72.25% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@FFroehlich
Copy link
Member

Hm, there is documentation/ExampleJax.ipynb and python/examples/example_jax/ExampleJax.ipynb. The former should be a symlink to the latter, but it is not. Seems like the two have diverged. Looks like those were two independent files from the beginning (#1996).

@FFroehlich: can you please check which one to keep?

You picked the right one, let’s go with python/examples/example_jax/ExampleJax.ipynb

@dweindl dweindl linked an issue Mar 7, 2024 that may be closed by this pull request
@dweindl dweindl merged commit b1bd988 into AMICI-dev:develop Mar 7, 2024
18 checks passed
@dweindl dweindl deleted the doc_fixjax branch March 7, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: Fix title in ExampleJax
2 participants