Fix Solver operator== and copyctor #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few recently added members were missing. Constraints were not copied when cloning a Solver.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2388 +/- ##
===========================================
- Coverage 77.67% 76.27% -1.41%
===========================================
Files 324 319 -5
Lines 20872 20714 -158
Branches 1458 1458
===========================================
- Hits 16213 15799 -414
- Misses 4656 4911 +255
- Partials 3 4 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few recently added members were missing. Constraints were not copied when cloning a Solver.