-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.25.0 #2433
Merged
Merged
Release 0.25.0 #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's reduce the number of package configuration files...
…`ExpData`. (AMICI-dev#2396) This avoids shading the `ExpData` class by `amici.swig_wrappers.ExpData`. The old implementation prevented using e.g. `isinstance(x, amici.ExpData)`. This required also: * Moving some annotation types and `_get_ptr` from `amici.swig_wrappers` to the swig-generated `amici.py` * Some smaller changes to allow for using `from __future__ import annotations` in `amici.py` Closes AMICI-dev#2380
NEP 29: > On Apr 05, 2024 drop support for Python 3.9
* Run pyupgrade for python>=3.10 * Update configuration for recent ruff manual changes: * .pre-commit-config.yam * pyproject.toml
Deploy releases (actual releases, not only release branches) to Docker Hub. Closes AMICI-dev#2383
Fix test failures related to switching from macos-12 to macos-14-arm64. Fixes AMICI-dev#2415.
Remove setup.cfg, originally removed in AMICI-dev#2408, accidentally re-added in AMICI-dev#2391
… root functions (AMICI-dev#2417) Don't compute things we don't need. For my test model, this reduces code generation time from 76s to 12s (-83%).
Make it easier to find out where warnings originate from.
... and show numpy version detected by CMake
When using the Python interface, we don't rely on C(++) output anywhere anymore, and thus, we don't need wurlitzer anymore. Closes AMICI-dev#2409
Previously, in some cases (see AMICI-dev#2426), event assignments to compartments would result in incorrect concentrations because an incorrect post-event volume was used. This is fixed here. Closes AMICI-dev#2426.
…ts (AMICI-dev#2425) Event-assignments to compartments weren't supported yet, now they are. Compartments that are targets of event assignments are now processed as "species", the same way as it is already done for parameters that are targets of event assignments. Closes AMICI-dev#2424. --------- Co-authored-by: Fabian Fröhlich <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2433 +/- ##
==========================================
+ Coverage 77.71% 77.82% +0.10%
==========================================
Files 324 324
Lines 20925 20928 +3
Branches 1464 1464
==========================================
+ Hits 16262 16287 +25
+ Misses 4660 4638 -22
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dweindl
force-pushed
the
release_0.25.0
branch
2 times, most recently
from
May 8, 2024 07:02
e237980
to
a0566b0
Compare
FFroehlich
approved these changes
May 8, 2024
…MICI-dev#2429) Check whether we are able to handle a given event according to its `useValuesFromTriggerTime` setting. See also AMICI-dev#2427. Does not affect SBML test suite stats. Closes AMICI-dev#2427.
for Python 3.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.