Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.26.2 #2497

Merged
merged 10 commits into from
Sep 26, 2024
Merged

Release 0.26.2 #2497

merged 10 commits into from
Sep 26, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Sep 24, 2024

No description provided.

dweindl added 5 commits August 1, 2024 22:39
Naming scheme changed. Use provided library to constructs paths.
* Add DuezWie2024

* Add SchmiesterBra2024

* JakstaiteZho2024
There are again many test failures due to timeouts when accessing remote test files.
Cache those.

Closes AMICI-dev#2378
Rename AmiciConfig.cmake->AmiciConfig.cmake.in so that CMake doesn't discover the template file when searching for the package configuration.
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.86%. Comparing base (b0d79ff) to head (e64ea4f).
Report is 114 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2497      +/-   ##
==========================================
+ Coverage   77.68%   77.86%   +0.18%     
==========================================
  Files         324      324              
  Lines       20941    20945       +4     
  Branches     1456     1456              
==========================================
+ Hits        16267    16309      +42     
+ Misses       4671     4633      -38     
  Partials        3        3              
Flag Coverage Δ
cpp 76.26% <100.00%> (+2.82%) ⬆️
cpp_python 34.09% <100.00%> (+0.01%) ⬆️
petab 36.62% <0.00%> (-0.01%) ⬇️
python 72.42% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/splines.py 83.82% <100.00%> (+4.32%) ⬆️

... and 2 files with indirect coverage changes

@dweindl dweindl self-assigned this Sep 25, 2024
dweindl and others added 5 commits September 25, 2024 10:46
Fixes AMICI-dev#2498

Fixes an assertion that broke due to sympy's recent change that made float and int compare unequal.

Also ensure an opened test file is closed properly and prevent ResourceWarnings.
Just small changes to CMake files.
@dweindl dweindl marked this pull request as ready for review September 25, 2024 13:33
@dweindl dweindl requested a review from a team as a code owner September 25, 2024 13:33
@dweindl dweindl merged commit 3dca16e into AMICI-dev:master Sep 26, 2024
27 checks passed
@dweindl dweindl deleted the release_0.26.2 branch September 26, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants