Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark model tests: fix gradients checks #2512

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Sep 27, 2024

  • Fix gradient checks. Previously, failing test would not have been reported (see Reduce tolerances in benchmark model gradient checks #2511).
    Quite some tests are now skipped, but better to test some than none... To be re-enabled later.
  • Sort test cases to avoid issues with pytest-xdist.
  • Refactor

Requires ICB-DCM/fiddy#37

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.73%. Comparing base (be02a6e) to head (7f5e173).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2512      +/-   ##
===========================================
+ Coverage    77.66%   77.73%   +0.07%     
===========================================
  Files          324      324              
  Lines        20951    20951              
  Branches      1451     1451              
===========================================
+ Hits         16271    16287      +16     
+ Misses        4677     4661      -16     
  Partials         3        3              
Flag Coverage Δ
cpp 73.48% <ø> (+0.07%) ⬆️
cpp_python 34.11% <ø> (ø)
petab 36.62% <ø> (ø)
python 72.29% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@dweindl dweindl force-pushed the 2511_benchmark_gradcheck branch from 3feb247 to 36c2038 Compare September 30, 2024 06:22
@dweindl dweindl changed the title Benchmark model tests: reduce gradient check tolerances Benchmark model tests: fix gradients checks Sep 30, 2024
@dweindl dweindl marked this pull request as ready for review September 30, 2024 11:00
@dweindl dweindl requested a review from a team as a code owner September 30, 2024 11:00
@dweindl dweindl self-assigned this Sep 30, 2024
@dweindl dweindl force-pushed the 2511_benchmark_gradcheck branch from e9f9e8e to d6c5c11 Compare September 30, 2024 18:39
Also sort test cases to avoid issues with pytest-xdist
@dweindl dweindl force-pushed the 2511_benchmark_gradcheck branch from d6c5c11 to 7f5e173 Compare October 1, 2024 12:20
@dweindl dweindl merged commit 8bd63f3 into AMICI-dev:develop Oct 2, 2024
20 checks passed
@dweindl dweindl deleted the 2511_benchmark_gradcheck branch October 2, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants