Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sphinx<8 / update sphinx config for sphinx8 #2532

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 8, 2024

Some dependency lifted there sphinx<8 requirement, but this leads to a number of issues with other dependencies. Therefore, require sphinx<8 for now.

Anyways fix some upcoming issue with sphinx 8 when doc2path will return something path-like (see ICB-DCM/pyPESTO#1482).

Not a problem yet, but this change prevents issues once we upgrade to sphinx 8 and doc2path will return something path-like.

See ICB-DCM/pyPESTO#1482
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.77%. Comparing base (cd56633) to head (7d6578b).
Report is 86 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2532   +/-   ##
========================================
  Coverage    77.77%   77.77%           
========================================
  Files          325      325           
  Lines        21048    21048           
  Branches      1472     1472           
========================================
  Hits         16371    16371           
  Misses        4650     4650           
  Partials        27       27           
Flag Coverage Δ
cpp 73.49% <ø> (ø)
cpp_python 34.03% <ø> (ø)
petab 37.04% <ø> (ø)
python 72.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe +24 450 MB AA-Turner, tk0miya

🚮 Removed packages: pypi/[email protected]

View full report↗︎

@dweindl dweindl changed the title Update sphinx config for sphinx8 Pin sphinx<8 / update sphinx config for sphinx8 Oct 8, 2024
@dweindl dweindl marked this pull request as ready for review October 8, 2024 09:08
@dweindl dweindl requested a review from a team as a code owner October 8, 2024 09:08
@dweindl dweindl merged commit 2784887 into AMICI-dev:develop Oct 8, 2024
19 of 20 checks passed
@dweindl dweindl deleted the fix_sphinx8 branch October 8, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants