Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor symbolic event processing #2538

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 9, 2024

Extract some neutral changes from #1539 to reduce the diff there and avoid conflicts.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.33%. Comparing base (6261491) to head (a309b8b).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
python/sdist/amici/de_model.py 85.71% 1 Missing ⚠️
python/sdist/amici/import_utils.py 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2538      +/-   ##
===========================================
- Coverage    77.76%   76.33%   -1.44%     
===========================================
  Files          325      320       -5     
  Lines        21047    20892     -155     
  Branches      1473     1473              
===========================================
- Hits         16367    15947     -420     
- Misses        4653     4921     +268     
+ Partials        27       24       -3     
Flag Coverage Δ
cpp 73.50% <85.71%> (+0.03%) ⬆️
cpp_python 34.04% <64.28%> (+0.01%) ⬆️
petab ?
python 72.33% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/de_model.py 92.53% <85.71%> (-0.10%) ⬇️
python/sdist/amici/import_utils.py 88.37% <85.71%> (ø)

... and 23 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review October 9, 2024 07:29
@dweindl dweindl requested a review from a team as a code owner October 9, 2024 07:29
@dweindl dweindl self-assigned this Oct 9, 2024
Extract some neutral changes from AMICI-dev#1539 to reduce the diff there and avoid conflicts.
@dweindl dweindl force-pushed the refactor_compute_eq branch from f73f45f to 63b1778 Compare October 9, 2024 08:55
@dweindl dweindl merged commit b7a3e91 into AMICI-dev:develop Oct 9, 2024
24 of 26 checks passed
@dweindl dweindl deleted the refactor_compute_eq branch October 9, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants